Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: Builder refactorization (part 1...) #2286

Merged
merged 29 commits into from
Sep 6, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 29, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

It should not produce visible user changes, it's a tentative factorization of the legacy arduino-builder code, in this case related to the sketch builder.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 69.98% and project coverage change: +0.01% 🎉

Comparison is base (0054738) 63.26% compared to head (bf04109) 63.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2286      +/-   ##
==========================================
+ Coverage   63.26%   63.28%   +0.01%     
==========================================
  Files         219      215       -4     
  Lines       19537    19549      +12     
==========================================
+ Hits        12361    12371      +10     
- Misses       6091     6098       +7     
+ Partials     1085     1080       -5     
Flag Coverage Δ
unit 63.28% <69.98%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...duino/builder/preprocessor/arduino_preprocessor.go 0.00% <0.00%> (ø)
legacy/builder/create_cmake_rule.go 8.30% <0.00%> (ø)
legacy/builder/types/context.go 94.04% <ø> (ø)
legacy/builder/types/types.go 100.00% <ø> (+14.28%) ⬆️
legacy/builder/phases/sizer.go 45.56% <50.00%> (ø)
legacy/builder/recipe_runner.go 72.72% <50.00%> (ø)
legacy/builder/builder_utils/utils.go 71.29% <56.00%> (-0.75%) ⬇️
arduino/builder/sketch.go 54.31% <65.38%> (+0.27%) ⬆️
commands/compile/compile.go 69.05% <69.64%> (-0.13%) ⬇️
arduino/builder/utils/utils.go 72.95% <72.95%> (ø)
... and 15 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmaglie and others added 27 commits September 5, 2023 16:18
#32

* refactor AddAdditionalEntriesToContext in a function

* use the new function in all the tests

* Move the assignaton of LibrariesResolutionResults inside the ResolveLibrary func

The ResolveLibrary func is only called by the ContainerFindIncludes

* rename bPath to buildPath

* cleanup usless tests

* remove shadowed variable
@cmaglie cmaglie changed the title legacy: Builder refactorization legacy: Builder refactorization (part 1...) Sep 6, 2023
@cmaglie cmaglie marked this pull request as ready for review September 6, 2023 08:46
@cmaglie cmaglie self-assigned this Sep 6, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 6, 2023
@cmaglie cmaglie merged commit 72c32ca into arduino:master Sep 6, 2023
92 checks passed
@cmaglie cmaglie deleted the builder_refactor branch September 6, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants