Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload port detector improvements #2288

Merged
merged 4 commits into from
Aug 31, 2023

Revert "Extend timeout if candidate port is lost in any case"

0ff1377
Select commit
Loading
Failed to load commit list.
Merged

Upload port detector improvements #2288

Revert "Extend timeout if candidate port is lost in any case"
0ff1377
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 31, 2023 in 0s

63.10% (target 30.00%)

View this Pull Request on Codecov

63.10% (target 30.00%)

Details

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.11% 🎉

Comparison is base (304d48c) 62.98% compared to head (0ff1377) 63.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           0.34.x    #2288      +/-   ##
==========================================
+ Coverage   62.98%   63.10%   +0.11%     
==========================================
  Files         221      221              
  Lines       19746    19747       +1     
==========================================
+ Hits        12438    12462      +24     
+ Misses       6206     6186      -20     
+ Partials     1102     1099       -3     
Files Changed Coverage Δ
commands/upload/upload.go 73.73% <33.33%> (-0.13%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.