Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: Builder refactorization (part 2...) #2298

Merged
merged 20 commits into from
Sep 8, 2023

remove unused struct FailIfBuildPathEqualsSketchPath

f57fbeb
Select commit
Loading
Failed to load commit list.
Merged

legacy: Builder refactorization (part 2...) #2298

remove unused struct FailIfBuildPathEqualsSketchPath
f57fbeb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 8, 2023 in 1s

63.82% (target 30.00%)

View this Pull Request on Codecov

63.82% (target 30.00%)

Details

Codecov Report

Patch coverage: 81.60% and project coverage change: +0.44% 🎉

Comparison is base (1c110e9) 63.37% compared to head (f57fbeb) 63.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2298      +/-   ##
==========================================
+ Coverage   63.37%   63.82%   +0.44%     
==========================================
  Files         214      214              
  Lines       19551    19794     +243     
==========================================
+ Hits        12390    12633     +243     
+ Misses       6075     6074       -1     
- Partials     1086     1087       +1     
Files Changed Coverage Δ
legacy/builder/create_cmake_rule.go 8.30% <0.00%> (ø)
legacy/builder/test/helper.go 100.00% <ø> (+20.83%) ⬆️
legacy/builder/types/context.go 91.37% <ø> (-2.67%) ⬇️
legacy/builder/phases/sizer.go 44.11% <41.66%> (-1.45%) ⬇️
...der/wipeout_build_path_if_build_options_changed.go 78.84% <50.00%> (ø)
commands/compile/compile.go 71.42% <60.00%> (+0.08%) ⬆️
legacy/builder/phases/linker.go 80.23% <71.79%> (-2.05%) ⬇️
arduino/builder/utils/utils.go 76.49% <80.00%> (+7.64%) ⬆️
legacy/builder/phases/core_builder.go 77.77% <86.56%> (+6.22%) ⬆️
legacy/builder/phases/libraries_builder.go 80.37% <89.79%> (+4.05%) ⬆️
... and 7 more

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.