Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bye bye legacy! #2317

Merged
merged 8 commits into from
Sep 15, 2023
Merged

Bye bye legacy! #2317

merged 8 commits into from
Sep 15, 2023

Conversation

alessio-perugini
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Removing the legacy pkg

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini added the topic: code Related to content of the project itself label Sep 14, 2023
@alessio-perugini alessio-perugini self-assigned this Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 73.92% and project coverage change: -0.27% ⚠️

Comparison is base (6d57ce6) 63.31% compared to head (4e1afd1) 63.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2317      +/-   ##
==========================================
- Coverage   63.31%   63.04%   -0.27%     
==========================================
  Files         202      200       -2     
  Lines       19204    19206       +2     
==========================================
- Hits        12159    12109      -50     
- Misses       6015     6051      +36     
- Partials     1030     1046      +16     
Flag Coverage Δ
unit 63.04% <73.92%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
arduino/builder/builder.go 71.42% <69.87%> (-8.36%) ⬇️
arduino/builder/export_cmake.go 7.98% <75.00%> (ø)
arduino/builder/build_options_manager.go 80.19% <100.00%> (+0.40%) ⬆️
arduino/builder/core.go 73.84% <100.00%> (ø)
arduino/builder/libraries.go 81.25% <100.00%> (ø)
arduino/builder/linker.go 76.71% <100.00%> (-0.63%) ⬇️
arduino/builder/preprocess_sketch.go 100.00% <100.00%> (ø)
arduino/builder/recipe.go 76.31% <100.00%> (ø)
arduino/builder/sizer.go 47.59% <100.00%> (ø)
arduino/builder/sketch.go 63.24% <100.00%> (-0.32%) ⬇️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini force-pushed the bye_bye_legacy branch 2 times, most recently from 9c073c1 to 99ccfb5 Compare September 15, 2023 16:10
Base automatically changed from refactor_legacy_test_part4 to master September 15, 2023 16:51
@alessio-perugini alessio-perugini merged commit 4c0d72e into master Sep 15, 2023
202 checks passed
@alessio-perugini alessio-perugini deleted the bye_bye_legacy branch September 15, 2023 17:38
@cmaglie cmaglie changed the title [skip-changelog] bye bye legacy Bye bye legacy! Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants