[breaking] Eliminate BoardListWatchRequest Interrupt from the grpc api and make it server streaming only
#2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2330 +/- ##
==========================================
- Coverage 63.08% 63.07% -0.01%
==========================================
Files 200 201 +1
Lines 19260 19233 -27
==========================================
- Hits 12150 12132 -18
+ Misses 6061 6050 -11
- Partials 1049 1051 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
force-pushed
the
2283-eliminate-boardlistwatchrequestinterrupt-from-the-grpc-api-make-it-server-streaming-only
branch
from
9e61ef6
to
6c32a9c
Compare
alessio-perugini
changed the title
alessio-perugini
requested review from
cmaglie,
umbynos and
MatteoPologruto
alessio-perugini
changed the title
Interrupt from the grpc api and make it server streaming only
umbynos
approved these changes
Sep 22, 2023
|
Remember to update the PR message and update |
alessio-perugini
changed the title
Interrupt from the grpc api and make it server streaming onlyInterrupt from the grpc api and make it server streaming only
umbynos
approved these changes
Sep 22, 2023
|
alessio-perugini
deleted the
2283-eliminate-boardlistwatchrequestinterrupt-from-the-grpc-api-make-it-server-streaming-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
We removed the streaming part of the client side.
What is the current behavior?
We have bidirectional streaming of client<-> server and we leverage the use of
Interruptfield to stop the communication.What is the new behavior?
We simply make this server streaming only and we remove the Interrupt field from the API.
Does this PR introduce a breaking change, and is titled accordingly?
We removed the
Interruptfield fromBoardListWatchRequestmessage.We removed the stream of BoardListWatchRequest in the
BoardListWatchrpc:rpc BoardListWatch(BoardListWatchRequest) returns (stream BoardListWatchResponse);Other information