Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: Fixed regression on compile --preprocess output #2339

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 25, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixed a regression after legacy builder refactoring.

What is the current behavior?

Preprocessor output is always displayed.

What is the new behavior?

The preprocessor output is displayed only with --preprocess flag.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie self-assigned this Sep 25, 2023
@cmaglie cmaglie added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 25, 2023
@cmaglie cmaglie changed the title legacy: Fixed regression on'compile --preprocess output legacy: Fixed regression oncompile --preprocess output Sep 25, 2023
@cmaglie cmaglie changed the title legacy: Fixed regression oncompile --preprocess output legacy: Fixed regression on compile --preprocess output Sep 25, 2023
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 53.84% and project coverage change: -0.01% ⚠️

Comparison is base (5a4f48b) 63.06% compared to head (6f52439) 63.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2339      +/-   ##
==========================================
- Coverage   63.06%   63.06%   -0.01%     
==========================================
  Files         201      201              
  Lines       19259    19259              
==========================================
- Hits        12146    12145       -1     
- Misses       6059     6060       +1     
  Partials     1054     1054              
Flag Coverage Δ
unit 63.06% <53.84%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
commands/compile/compile.go 68.85% <50.00%> (-0.14%) ⬇️
arduino/builder/builder.go 71.42% <57.14%> (-0.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 422aa87 into arduino:master Sep 25, 2023
93 checks passed
@cmaglie cmaglie deleted the fix_preprocess_output branch September 25, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants