Fixed missing ARDUINO_USER_AGENT env var setting.
#2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
type: imperfection
|
We must backport this one in the 0.35.x branch so it gets released with the next Arduino IDE @kittaakos @umbynos |
cmaglie
changed the title
ARDUINO_USER_AGENT env var setting.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2501 +/- ##
==========================================
- Coverage 68.88% 68.81% -0.08%
==========================================
Files 204 204
Lines 20455 20457 +2
==========================================
- Hits 14091 14078 -13
- Misses 5206 5222 +16
+ Partials 1158 1157 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
approved these changes
Jan 15, 2024
umbynos
approved these changes
Jan 15, 2024
4 tasks
cmaglie
added a commit
that referenced
this pull request
Jan 16, 2024
* Added integration test * Fixed missing ARDUINO_USER_AGENT env var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Fix
ARDUINO_USER_AGENTenv var.What is the current behavior?
The
ARDUINO_USER_AGENTis not set during the build.What is the new behavior?
The
ARDUINO_USER_AGENTis set during the build.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Should fix #2499