Add programmer field to sketch profile and --profile flag to debug command
#2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
3 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2505 +/- ##
==========================================
+ Coverage 68.90% 68.95% +0.05%
==========================================
Files 204 204
Lines 20448 20517 +69
==========================================
+ Hits 14089 14148 +59
- Misses 5209 5216 +7
- Partials 1150 1153 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MatteoPologruto
force-pushed
the
profile-programmer
branch
from
bd3e7d5
to
d8cdd5d
Compare
MatteoPologruto
force-pushed
the
profile-programmer
branch
from
d8cdd5d
to
1f36816
Compare
cmaglie
approved these changes
Feb 2, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Feature
What is the current behavior?
The
programmerinformation is not included in the profile and it is not possible to use the--profileflag to run thedebugcommand.What is the new behavior?
A profile can have its
programmer, which will be used inuploadanddebugcommands when the--profileflag is passed or a default profile is set. It can be overwritten using the--programmerflag.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information