Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-changelog] fixup, use environment #2542

Merged
merged 2 commits into from
Feb 16, 2024
Merged

[skip-changelog] fixup, use environment #2542

merged 2 commits into from
Feb 16, 2024

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Feb 16, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] UPGRADING.md has been updated with a migration guide (for breaking changes)
    - [ ] configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

infra enhancement

What is the current behavior?

fixup for #2541

What is the new behavior?

The role is assumed correctly

Does this PR introduce a breaking change, and is titled accordingly?

Other information

  • environment production created

@umbynos umbynos added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Feb 16, 2024
@umbynos umbynos self-assigned this Feb 16, 2024
.github/workflows/publish-go-nightly-task.yml Outdated Show resolved Hide resolved
.github/workflows/release-go-task.yml Outdated Show resolved Hide resolved
Co-authored-by: Massimo Schenone <[email protected]>
Copy link
Contributor

@mschenone mschenone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umbynos umbynos merged commit a93f755 into master Feb 16, 2024
5 checks passed
@umbynos umbynos deleted the fixup-iam-roles branch February 16, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants