Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dep from configuration package in DiscoveryManager #2568

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 19, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Just a small code refactoring.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 19, 2024
@cmaglie cmaglie self-assigned this Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.48%. Comparing base (0d86bf5) to head (999d73b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2568   +/-   ##
=======================================
  Coverage   69.47%   69.48%           
=======================================
  Files         205      205           
  Lines       20203    20204    +1     
=======================================
+ Hits        14037    14038    +1     
  Misses       5045     5045           
  Partials     1121     1121           
Flag Coverage Δ
unit 69.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 31e3288 into arduino:master Mar 19, 2024
98 checks passed
@cmaglie cmaglie deleted the conf_small_refactor branch March 19, 2024 15:39
@cmaglie
Copy link
Member Author

cmaglie commented Mar 25, 2024

Related to #2565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants