Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC: if an Upload request is canceled, immediately terminate the upload tool process. #2726

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Fixed process termination when upload call is canceled

5bbbe80
Select commit
Loading
Failed to load commit list.
Open

gRPC: if an Upload request is canceled, immediately terminate the upload tool process. #2726

Fixed process termination when upload call is canceled
5bbbe80
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 9, 2024 in 0s

67.66% (target 30.00%)

View this Pull Request on Codecov

67.66% (target 30.00%)

Details

Codecov Report

Attention: Patch coverage is 32.35294% with 23 lines in your changes missing coverage. Please review.

Project coverage is 67.66%. Comparing base (ac6ec6d) to head (5bbbe80).

Files with missing lines Patch % Lines
internal/mock_avrdude/main.go 0.00% 18 Missing ⚠️
commands/service_upload.go 68.75% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2726      +/-   ##
==========================================
- Coverage   67.68%   67.66%   -0.03%     
==========================================
  Files         234      235       +1     
  Lines       22285    22314      +29     
==========================================
+ Hits        15083    15098      +15     
- Misses       6017     6031      +14     
  Partials     1185     1185              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.