Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduced cloud state in sketchbook view #1896

Closed
wants to merge 1 commit into from
Closed

feat: introduced cloud state in sketchbook view #1896

wants to merge 1 commit into from

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Feb 20, 2023 •
edited
Loading

Motivation

Show cloud state in IDE2. Handle if there is no Internet connection.

Change description

For reviewers: please look at the internals design slides for the expected behavior.

1879.mp4

Other information

Closes #1879

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 20, 2023
@kittaakos kittaakos self-assigned this Feb 21, 2023
@kittaakos kittaakos marked this pull request as ready for review February 21, 2023 09:21
@kittaakos kittaakos mentioned this pull request Feb 21, 2023
Merged
4 tasks
AlbyIanna
AlbyIanna approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works. Code also looks great!

@kittaakos kittaakos marked this pull request as draft February 22, 2023 09:25
@kittaakos
Copy link
Contributor Author

Closing in favor of #1901 as a duplicate.

@kittaakos kittaakos closed this Feb 23, 2023
@kittaakos kittaakos added the conclusion: duplicate Has already been submitted label Feb 23, 2023
@kittaakos kittaakos deleted the #1879 branch February 24, 2023 11:04
@per1234 per1234 added the topic: cloud Related to Arduino Cloud and cloud sketches label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@91volt 91volt Awaiting requested review from 91volt

Assignees

@kittaakos kittaakos

Labels
conclusion: duplicate Has already been submitted topic: cloud Related to Arduino Cloud and cloud sketches topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce 'Cloud States' to the Sketchbook list of IDE2
3 participants
@kittaakos @AlbyIanna @per1234