Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable debug widget if unsupported by board #2342

Merged
merged 1 commit into from
Jan 31, 2024
Merged

feat: disable debug widget if unsupported by board #2342

merged 1 commit into from
Jan 31, 2024

Conversation

kittaakos
Copy link
Contributor

Motivation

Improve communication of no debugger support when accessed via the activity bar

gh-14.mp4

Change description

  • Disable the debug widget if the debugging is unsupported by the selected board + programmer + config options triplet. If debugging is unsupported, the message is the same as in the toolbar.
  • Remove the 'Add configuration...' select option from the debug widget.

Other information

Closes #14

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: debugger Related to the integrated debugger labels Jan 26, 2024
@pillo79
Copy link

pillo79 commented Jan 29, 2024

@kittaakos Love this, especially the fact that there's a clear indication of the issue preventing the debug from being active! 👍 🚀
Just out of curiosity, what does that text say in the case of the Nano ESP32 with the wrong "USB mode"?

Copy link

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@kittaakos
Copy link
Contributor Author

Just out of curiosity, what does that text say in the case of the Nano ESP32 with the wrong "USB mode"?

That's a good point. It just says that Debugging is not supported by 'Arduino Nano ESP32'. The CLI cannot provide more information when asked via the arduino-cli debug check command. It only tells whether it's supported or not. IDE2 says to the user what the CLI says.

Remove the 'Add configuration...' select option from the debug widget.

Closes #14

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos
Copy link
Contributor Author

Follow up: #2345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: debugger Related to the integrated debugger type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve communication of no debugger support when accessed via the activity bar
4 participants