Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upload using programmer by default if board requires it #2500

Merged
merged 2 commits into from
Sep 19, 2024
Merged

feat: upload using programmer by default if board requires it #2500

merged 2 commits into from
Sep 19, 2024

Conversation

giacomocusinato
Copy link
Collaborator

@giacomocusinato giacomocusinato commented Sep 5, 2024 •
edited
Loading

Motivation

#103

Change description

  1. Add utility to map grcp errors to custom generated CLI errors
  2. If default upload fails with ProgrammerIsRequiredForUploadError , perform upload request again using selected programmer

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@giacomocusinato
feat: decode grpc status objects and map them to protocol types
beabb80 
Status object thrown by grpc commands contains metadata that needs to be serialized in order to map it to custom errors generated through proto files grpc/grpc-web#399
@giacomocusinato
feat: upload using programmer by default if board requires it
3f325e0
@giacomocusinato giacomocusinato merged commit a5bf56f into main Sep 19, 2024
25 checks passed
@giacomocusinato giacomocusinato mentioned this pull request Sep 25, 2024
Closed
3 tasks
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 25, 2024
@per1234 per1234 mentioned this pull request Sep 26, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davegarthsimpson davegarthsimpson davegarthsimpson approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giacomocusinato @davegarthsimpson @per1234