Configure script path in shell-related task calls in umbrella tasks #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tasks for facilitating development and validation of shell scripts were recently adjusted to target specific scripts. After that change, it is necessary to specify the path to the script in the task call. For the convenience of the contributor, the taskfile contains some "umbrella" tasks that call all of the tasks of a given type. These call the shell-related tasks. Those calls were not updated at the time the shell tasks were changed to a targeted approach so previously they were not functional.
per1234
added
topic: infrastructure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 44 44
Lines 6800 6800
=======================================
Hits 6124 6124
Misses 553 553
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tasks for facilitating development and validation of shell scripts were recently adjusted to target specific scripts (#773). After that change, it is necessary to specify the path to the script in the task call.
For the convenience of the contributor, the taskfile contains some "umbrella" tasks that call all of the tasks of a given type. These call the shell-related tasks. Those calls were not updated at the time the shell tasks were changed to a targeted approach so previously they were not functional.