Skip to content

[PXCT-969] add tiny-ml-kit step file #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

Hannes7eicher
Copy link
Contributor

What This PR Changes

This PR adds the step file to the tiny ml kit

Contribution Guidelines

@Hannes7eicher Hannes7eicher self-assigned this Jun 11, 2025
@Hannes7eicher Hannes7eicher added documentation Improvements or additions to documentation arduino Bugs and fixes added by the Arduino Team labels Jun 11, 2025
@jhansson-ard
Copy link
Contributor

@Hannes7eicher let's run the preview so that nothing breaks!

Copy link

github-actions bot commented Jun 11, 2025

Preview Deployment

🚀 Preview this PR: https://6853e7215b22ba718cbfdd5d--docs-content.netlify.app
📍 Commit SHA: 8d151e7

@jhansson-ard
Copy link
Contributor

jhansson-ard commented Jun 11, 2025

I mean, through the direct URL it doesn't look good but then again I don't think people go there (also it didn't look good before either haha)

image

For me, I think it could be good enough!

Copy link
Contributor

@TaddyHC TaddyHC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hannes7eicher ! I agree with @jhansson-ard 's point in this case, since the hardware is in unlisted directory and so on. I'm not sure if the file should appear within the downloadable resources in this case (I think it should still appear, even if it is in unlisted directory), so I'd like to suggest by compressing the step file as we do and name as AKX00028-shield-step for example. Otherwise, based on the observation until now, lgtm

@jhansson-ard
Copy link
Contributor

True @TaddyHC ! It might be the name of the file that makes it not show, please @Hannes7eicher try to rename the file and let's see

@Hannes7eicher
Copy link
Contributor Author

Hannes7eicher commented Jun 19, 2025

@jhansson-ard @TaddyHC I compressed the file and renamed it to AKX00028-shield-step.

I checked the preview and it now appears in the download section, so I will go ahead and merge this.

Screenshot 2025-06-19 at 14 08 25

@Hannes7eicher Hannes7eicher merged commit d7cbd4b into main Jun 19, 2025
4 checks passed
@Hannes7eicher Hannes7eicher deleted the Hannes7eicher/TinyMachineLearningKit.STEP branch June 19, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino Bugs and fixes added by the Arduino Team documentation Improvements or additions to documentation preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants