fix: edit url for block browser items

[zeezo887]

Description

This resolves the issue where the edit URL of a block browser item fails to function properly when the browser name doesn't match the item module name.

Related Issues

Relates to #2278

[Tofandel]

Also just encountered this issue, the PR doesn't fix it entirely though

getModuleNameByModel() is not working properly if the model has a different name than the module (which it could have)

The fix is

    function getModuleNameByModel($model)
    {
        try {
            return TwillCapsules::getCapsuleForModel($model)->getModule();
        } catch (NoCapsuleFoundException) {
            return Str::plural(lcfirst(class_basename($model)));
        }
    }

    public function getCapsuleForModel(string|TwillModelContract $model): Capsule
    {
        if ($model instanceof TwillModelContract) {
            $model = get_class($model);
        }

        $model = class_basename($model);

        $capsule = $this->getRegisteredCapsules()->first(function (Capsule $capsule) use ($model) {
            return $capsule->getSingular() === $model;
        });

        if (!$capsule) {
            throw new NoCapsuleFoundException($model);
        }

        return $capsule;
    }

[Tofandel]

Suggested change

	$relatedType = $object->getRelation('pivot')->related_type;
	$relation = str_contains($relatedType, '\\')
	? getModuleNameByModel($relatedType)
	: $relatedType;
	return moduleRoute(
	$relation,
	config('twill.block_editor.browser_route_prefixes.' . $relation),
	'edit',
	$object->id
	);
	}
	$module = getModuleNameByModel($object);
	return moduleRoute(
	$module,
	config('twill.block_editor.browser_route_prefixes.' . $module),
	'edit',
	$object->id
	);
	}

[Tofandel]

Even with all this changes, the issue is still not fixed, newly added relations do get the correct link, but not the ones that were loaded when loading the page

[Tofandel]

There is another

'edit' => $relatedElement->adminEditUrl ?? moduleRoute(
      $moduleName ?? $relation,
      $routePrefix ?? '',
      'edit',
      $relatedElement->id
  ),

In handle browsers that needs to be replaced with 'edit' => $this->getAdminUrl($relatedElement)

After that it works correctly

[zeezo887]

@Tofandel Thanks for this! I didn't consider that a module name could be different from the model. Your suggested changes worked fine.

[Tofandel]

Thanks, there is still this https://github.com/area17/twill/pull/2533/files#diff-3b134878262a01ad247d37cebcf578142d170ece67db85d1c31b8d0831c29c71R204-R208
To change according to my last comment

[Tofandel]

For backward compatibility

[Tofandel]

Suggested change

	public function getAdminEditUrl($object): mixed
	public function getAdminEditUrl($object, ?string $routePrefix): mixed

[Tofandel]

Suggested change

	config('twill.block_editor.browser_route_prefixes.' . $module),
	$routePrefix ?? config('twill.block_editor.browser_route_prefixes.' . $module),

[Tofandel]

Suggested change

	'edit' => $this->getAdminEditUrl($relatedElement),
	'edit' => $this->getAdminEditUrl($relatedElement, $routePrefix),