Add appveyor support #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aredridel
reviewed
Aug 9, 2018
| @@ -48,7 +48,7 @@ async function buildArchPackage(os, cpu, version, pre) { | |||
| debug("building architecture specific package", os, cpu, version, pre) | |||
|
|
|||
| const platform = os == 'win' ? 'win32' : os | |||
| const arch = os == 'win' && cpu == 'ia32' ? 'x86' : cpu | |||
| const arch = os == 'win' && cpu == 'ia32' ? ['x86', 'ia32'] : cpu | |||
There was a problem hiding this comment.
Where are these coming from / used? Is there a nodejs binary release marked ia32?
There was a problem hiding this comment.
This change is necessary for 32bit Windows to install the npm package node, otherwise npm will throw
error C:\Users\IEUser\babel\packages\babel-preset-env\node_modules\node: Command failed.
Exit code: 1
Command: node installArchSpecificPackage
Arguments:
Directory: C:\Users\IEUser\babel\packages\babel-preset-env\node_modules\node
Output:
npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for [email protected]: wanted {"os":"win32","arch":"x86"} (current: {"os":"win3
2","arch":"ia32"})
npm ERR! notsup Valid OS: win32
npm ERR! notsup Valid Arch: x86
npm ERR! notsup Actual OS: win32
npm ERR! notsup Actual Arch: ia32
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\IEUser\AppData\Roaming\npm-cache\_logs\2019-12-17T01_34_23_329Z-debug.log
internal/modules/cjs/loader.js:628
throw err;
^
Error: Cannot find module 'node-win-x86/package.json'
As long as ia32 is mapped to install node-win-x86 instead, we should state this at its package.json that cpus: ["x86", "ia32"] is supported.
|
These were taken from #45 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.