ADBDEV-5496: Use Postgres allocator for ZSTD (GPDB 7) #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bandetto
force-pushed
the
ADBDEV-5496
branch
2 times, most recently
from
1def093 to
7d51b44
Compare
|
maybe change this
to to avoid confusion? |
RekGRpth
reviewed
Dec 6, 2024
src/backend/storage/file/buffile.c
Outdated
Comment on lines
1311
to
1312
| ZSTD_customMem zstdCustomMem; | ||
| zstdCustomMem.customAlloc = zstdCustomAlloc; |
There was a problem hiding this comment.
In the original commit here and below, the new variable declaration was closer to the other declarations.
bandetto
pushed a commit
that referenced
this pull request
Dec 11, 2024
gpdb uses zstd to compress workfiles, but it can't control memory allocation within zstd. Meanwhile, zstd allocates as much memory as it needs which results in ambiguous error message in a case of memory exhaustion and can make OOM killer stop gpdb processes with force. This patch forces zstd to use our custom allocator which can keep track of allocated memory. Since this zstd feature is experimental and its api can change, we also had to link zstd statically. (cherry picked from commit 7185bf8) --- Changes were adapted to GPDB 7. Autoconf check was adjusted to behave the same way as the existing code. Both PRs from the original task were integrated into this commit.
bandetto
force-pushed
the
ADBDEV-5496
branch
from
7d51b44 to
12515b1
Compare
gpdb uses zstd to compress workfiles, but it can't control memory allocation within zstd. Meanwhile, zstd allocates as much memory as it needs which results in ambiguous error message in a case of memory exhaustion and can make OOM killer stop gpdb processes with force. This patch forces zstd to use our custom allocator which can keep track of allocated memory. Since this zstd feature is experimental and its api can change, we also had to link zstd statically. (cherry picked from commit 7185bf8) --- Changes were adapted to GPDB 7. Autoconf check was adjusted to behave the same way as the existing code. Both PRs from the original task were integrated into this commit.
bandetto
force-pushed
the
ADBDEV-5496
branch
from
12515b1 to
d71ab9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of 7185bf8.
Changes were adapted to GPDB 7. Autoconf check was adjusted to behave the same way as the existing code. Both PRs from the original task were integrated into this commit.
This PR should be rebased to preserve authorship.