-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADBDEV-3929 Fix deadlock by shared SegmentGeneral CTE & planning failure by sharing General CTE #640
Commits on Nov 21, 2023
-
Fix deadlock by shared SegmentGeneral CTE
Depending on the usage of the shared CTE with SegmentGeneral subplan, the number of segments the CTE are executed on may be single for joins with Singleton nodes, and multiple for hashed nodes. In the current implementation this may lead to deadlock if the CTE is used for both join targets: the Join with the Singleton node results in the Share Input Scan producer being executed on a single segment, while the Join with the Hashed node creates Share Input Scan reader on multiple segments, so the plan execution hangs. If we force execution of CTE on multiple segments as well, it will cause redundant motions in case of joining the CTE with another SegmentGeneral. At the moment of constructing and sharing the CTE we don't know the rest of the plan, so we can't predict the correct CTE locus. Because replicated tables are considered small, the most universal and optimal way to fix deadlock would be to inline CTE scans with SegmentGeneral locus. This patch fixes the deadlock by disabling sharing CTE if the subplan has SegmentGeneral locus.
Vyacheslav Kompan committedNov 21, 2023 Configuration menu - View commit details
-
Copy full SHA for e5037d9 - Browse repository at this point
Copy the full SHA e5037d9View commit details -
Vyacheslav Kompan committed
Nov 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 66ae556 - Browse repository at this point
Copy the full SHA 66ae556View commit details -
Reuse CTE subplan & rename shared_plan to subplan
Vyacheslav Kompan committedNov 21, 2023 Configuration menu - View commit details
-
Copy full SHA for d5ff703 - Browse repository at this point
Copy the full SHA d5ff703View commit details -
Fix potential memleak with singleton CTE subplan
Vyacheslav Kompan committedNov 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 55c56c7 - Browse repository at this point
Copy the full SHA 55c56c7View commit details -
Remove alternative solution comment
Vyacheslav Kompan committedNov 21, 2023 Configuration menu - View commit details
-
Copy full SHA for aeb7023 - Browse repository at this point
Copy the full SHA aeb7023View commit details
Commits on Nov 26, 2023
-
Adjust comments on cte sharing
Vyacheslav Kompan committedNov 26, 2023 Configuration menu - View commit details
-
Copy full SHA for a6653b3 - Browse repository at this point
Copy the full SHA a6653b3View commit details
Commits on Nov 27, 2023
-
Fix comment in expected test output
Vyacheslav Kompan committedNov 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 3b03d5e - Browse repository at this point
Copy the full SHA 3b03d5eView commit details -
Vyacheslav Kompan committed
Nov 27, 2023 Configuration menu - View commit details
-
Copy full SHA for db9c090 - Browse repository at this point
Copy the full SHA db9c090View commit details -
Remove test for joining 2 SegmentGenerals
Vyacheslav Kompan committedNov 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 2439643 - Browse repository at this point
Copy the full SHA 2439643View commit details
Commits on Nov 30, 2023
-
Vyacheslav Kompan committed
Nov 30, 2023 Configuration menu - View commit details
-
Copy full SHA for c018626 - Browse repository at this point
Copy the full SHA c018626View commit details
Commits on Dec 4, 2023
-
Merge branch 'adb-6.x-dev' into ADBDEV-3929
Vyacheslav Kompan committedDec 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 040e40e - Browse repository at this point
Copy the full SHA 040e40eView commit details -
Vyacheslav Kompan committed
Dec 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 48e43bc - Browse repository at this point
Copy the full SHA 48e43bcView commit details
Commits on Dec 5, 2023
-
Vyacheslav Kompan committed
Dec 5, 2023 Configuration menu - View commit details
-
Copy full SHA for 10aa685 - Browse repository at this point
Copy the full SHA 10aa685View commit details
Commits on Dec 6, 2023
-
Co-authored-by: Viktor Kurilko <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d14a3d4 - Browse repository at this point
Copy the full SHA d14a3d4View commit details
Commits on Dec 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8437160 - Browse repository at this point
Copy the full SHA 8437160View commit details
Commits on Dec 8, 2023
-
Vyacheslav Kompan committed
Dec 8, 2023 Configuration menu - View commit details
-
Copy full SHA for d89f9da - Browse repository at this point
Copy the full SHA d89f9daView commit details -
Vyacheslav Kompan committed
Dec 8, 2023 Configuration menu - View commit details
-
Copy full SHA for 37323e4 - Browse repository at this point
Copy the full SHA 37323e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 921185c - Browse repository at this point
Copy the full SHA 921185cView commit details