Align documentation for COPY command with current parser implementation #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… COPY command. Problem description: In cases where the COPY command is used with new syntax where options are listed in parentheses, "FILL MISSING FIELD" option is causing a syntax error. Old syntax without parentheses works fine. Root cause: Parser's rule for every option in the list of options (nonterminal symbol copy_generic_opt_elem) currently expects that every option has a form of "string without spaces" plus optional "space" and "argument". 'FILL MISSING FIELD' doesn't match this pattern. Fix: Added handling of the "FILL MISSING FIELDS" option to the grammar file for the nonterminal symbol copy_generic_opt_elem.
…ess/input/copy.source
|
Allure report https://allure-ee.adsw.io/launch/60231 |
|
Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/877297 |
|
Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/877298 |
Reverted changes in grammar file from commit 5721ff2. Also updated COPY command test to check 'FILL_MISSING_FIELDS' 'ON_SEGMENT' '[LOG ERRORS] SEGMENT REJECT LIMIT <count> [ [ROWS] | PERCENT ]' 'IGNORE EXTERNAL PARTITIONS' 'NEWLINE' statements.
whitehawk
changed the title
|
Allure report https://allure-ee.adsw.io/launch/61997 |
|
Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/975477 |
|
Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/975478 |
|
Failed job Regression tests with ORCA on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/975468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated COPY command documentation to fix mismatches with parser implementation
for following statements:
'FILL_MISSING_FIELDS'
'ON_SEGMENT'
'[LOG ERRORS] SEGMENT REJECT LIMIT [ [ROWS] | PERCENT ]'
'IGNORE EXTERNAL PARTITIONS'
'NEWLINE'
Plus updated COPY test for minimal syntax check of these statements.