-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADBDEV-4152: Optimize the Explicit Redistribute application logic #666
Commits on Jan 30, 2024
-
Check for Motions before scan if requesting Explicit Redistribute Motion
Previously, `Explicit Redistribute Motion` was added if there were any motions in the subplan, ignoring any motions in `InitPlans`. This patch updates the logic: if an `Explicit Redistribute Motion` has no motions underneath it's subtree, then the row to update must originate from the same segment, and no `Explicit Redistribute Motion` is needed. If there are any motions, `Explicit Redistribute Motion` should be added only if there is a motion between the scan and the `ModifyTable` on the relation we are going to update. Even if previous Motions were performed on a leaf partition or inherited table, targetlists from Motions refer to relids of their parents. So, if relid has a superclass, we should check for inheritance instead of comparing Oids.
Configuration menu - View commit details
-
Copy full SHA for fa1e719 - Browse repository at this point
Copy the full SHA fa1e719View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51960cd - Browse repository at this point
Copy the full SHA 51960cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d5edb5 - Browse repository at this point
Copy the full SHA 4d5edb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbb6f6b - Browse repository at this point
Copy the full SHA cbb6f6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 684ac6a - Browse repository at this point
Copy the full SHA 684ac6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for da58c43 - Browse repository at this point
Copy the full SHA da58c43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 208903b - Browse repository at this point
Copy the full SHA 208903bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 848cc16 - Browse repository at this point
Copy the full SHA 848cc16View commit details -
Look into hashExprs for Redistribute Motion
While checking the assumption that the right subtree is more frequent, I found out that target list of `Redistribute Motion` may contain columns which are not used for distribution. Behavior was correct only because the right subtree is checked first. In cases when the scan would be in the left subtree, this is incorrect, and `hashExprs` need to be checked instead. Checking `hashExprs` may contain different structures that inherit `Expr` node. The structure we need is of type `Var`, because it's the only child of `Expr` node that we can get relation ID from.
Configuration menu - View commit details
-
Copy full SHA for b24fea9 - Browse repository at this point
Copy the full SHA b24fea9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2144872 - Browse repository at this point
Copy the full SHA 2144872View commit details -
Configuration menu - View commit details
-
Copy full SHA for 671b439 - Browse repository at this point
Copy the full SHA 671b439View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c19171 - Browse repository at this point
Copy the full SHA 7c19171View commit details -
Configuration menu - View commit details
-
Copy full SHA for e61fbf3 - Browse repository at this point
Copy the full SHA e61fbf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0e839c - Browse repository at this point
Copy the full SHA e0e839cView commit details -
Configuration menu - View commit details
-
Copy full SHA for aad110b - Browse repository at this point
Copy the full SHA aad110bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b775728 - Browse repository at this point
Copy the full SHA b775728View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e69fae - Browse repository at this point
Copy the full SHA 8e69faeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ebcff5 - Browse repository at this point
Copy the full SHA 9ebcff5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 951ece2 - Browse repository at this point
Copy the full SHA 951ece2View commit details -
Revert "Fix isChecking being enabled for INSERT ModifyTable after fir…
…st Explicit Motion" This reverts commit 8cfe09c. Explicit Redidistribute Motion is not requested unless IT IS UPDATE/DELETE
Configuration menu - View commit details
-
Copy full SHA for 049d111 - Browse repository at this point
Copy the full SHA 049d111View commit details -
Configuration menu - View commit details
-
Copy full SHA for db1b2f4 - Browse repository at this point
Copy the full SHA db1b2f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec27689 - Browse repository at this point
Copy the full SHA ec27689View commit details -
Configuration menu - View commit details
-
Copy full SHA for 894ffd3 - Browse repository at this point
Copy the full SHA 894ffd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d9eea9 - Browse repository at this point
Copy the full SHA 7d9eea9View commit details -
Revert "Change comments, since varnoold is used"
This reverts commit 955356e.
Configuration menu - View commit details
-
Copy full SHA for 3531176 - Browse repository at this point
Copy the full SHA 3531176View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0225657 - Browse repository at this point
Copy the full SHA 0225657View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5281022 - Browse repository at this point
Copy the full SHA 5281022View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7efdd12 - Browse repository at this point
Copy the full SHA 7efdd12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f609c4 - Browse repository at this point
Copy the full SHA 4f609c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe9905b - Browse repository at this point
Copy the full SHA fe9905bView commit details -
This reverts commit e5fbce1. Explicit Redistribute Motion here is unnecessary.
Configuration menu - View commit details
-
Copy full SHA for 98132eb - Browse repository at this point
Copy the full SHA 98132ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5f68e1 - Browse repository at this point
Copy the full SHA d5f68e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31f4f3e - Browse repository at this point
Copy the full SHA 31f4f3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a53ecd - Browse repository at this point
Copy the full SHA 5a53ecdView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf60efa - Browse repository at this point
Copy the full SHA bf60efaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a60385f - Browse repository at this point
Copy the full SHA a60385fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d91f93 - Browse repository at this point
Copy the full SHA 8d91f93View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0d7269 - Browse repository at this point
Copy the full SHA c0d7269View commit details -
Configuration menu - View commit details
-
Copy full SHA for a99c4b1 - Browse repository at this point
Copy the full SHA a99c4b1View commit details -
Revert "Fix nMotionsAbove not decrementing when we already found moti…
…ons" This reverts commit 99b32b3.
Configuration menu - View commit details
-
Copy full SHA for 43b562b - Browse repository at this point
Copy the full SHA 43b562bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f170f8 - Browse repository at this point
Copy the full SHA 2f170f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44e7492 - Browse repository at this point
Copy the full SHA 44e7492View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eb73d5 - Browse repository at this point
Copy the full SHA 7eb73d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6f5049 - Browse repository at this point
Copy the full SHA b6f5049View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0bebc8 - Browse repository at this point
Copy the full SHA b0bebc8View commit details
Commits on Feb 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 38beaa2 - Browse repository at this point
Copy the full SHA 38beaa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8c919c - Browse repository at this point
Copy the full SHA b8c919cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b98b7b - Browse repository at this point
Copy the full SHA 4b98b7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2c801a - Browse repository at this point
Copy the full SHA d2c801aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11be3ca - Browse repository at this point
Copy the full SHA 11be3caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73aac4c - Browse repository at this point
Copy the full SHA 73aac4cView commit details
Commits on Feb 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 053ea46 - Browse repository at this point
Copy the full SHA 053ea46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 289068b - Browse repository at this point
Copy the full SHA 289068bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f2299f - Browse repository at this point
Copy the full SHA 5f2299fView commit details
Commits on Feb 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a270ca1 - Browse repository at this point
Copy the full SHA a270ca1View commit details
Commits on Mar 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8d7fd19 - Browse repository at this point
Copy the full SHA 8d7fd19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2970372 - Browse repository at this point
Copy the full SHA 2970372View commit details
Commits on Mar 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4bef525 - Browse repository at this point
Copy the full SHA 4bef525View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16fc477 - Browse repository at this point
Copy the full SHA 16fc477View commit details -
Configuration menu - View commit details
-
Copy full SHA for de565c2 - Browse repository at this point
Copy the full SHA de565c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf188a4 - Browse repository at this point
Copy the full SHA bf188a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 267077f - Browse repository at this point
Copy the full SHA 267077fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ffca2a - Browse repository at this point
Copy the full SHA 4ffca2aView commit details
Commits on Mar 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9d35370 - Browse repository at this point
Copy the full SHA 9d35370View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54dec02 - Browse repository at this point
Copy the full SHA 54dec02View commit details -
Configuration menu - View commit details
-
Copy full SHA for a628050 - Browse repository at this point
Copy the full SHA a628050View commit details
Commits on Mar 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4b43f33 - Browse repository at this point
Copy the full SHA 4b43f33View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8ec1f0 - Browse repository at this point
Copy the full SHA d8ec1f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63f63cd - Browse repository at this point
Copy the full SHA 63f63cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4301bf6 - Browse repository at this point
Copy the full SHA 4301bf6View commit details
Commits on Mar 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 71dbb77 - Browse repository at this point
Copy the full SHA 71dbb77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e69424 - Browse repository at this point
Copy the full SHA 5e69424View commit details -
Configuration menu - View commit details
-
Copy full SHA for e32d271 - Browse repository at this point
Copy the full SHA e32d271View commit details -
Configuration menu - View commit details
-
Copy full SHA for d927e62 - Browse repository at this point
Copy the full SHA d927e62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d4550c - Browse repository at this point
Copy the full SHA 2d4550cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8504082 - Browse repository at this point
Copy the full SHA 8504082View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e6acf1 - Browse repository at this point
Copy the full SHA 3e6acf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc89960 - Browse repository at this point
Copy the full SHA bc89960View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd9b81f - Browse repository at this point
Copy the full SHA cd9b81fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f250be - Browse repository at this point
Copy the full SHA 3f250beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24a0b49 - Browse repository at this point
Copy the full SHA 24a0b49View commit details
Commits on Mar 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f2b9cbd - Browse repository at this point
Copy the full SHA f2b9cbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15d2190 - Browse repository at this point
Copy the full SHA 15d2190View commit details -
Configuration menu - View commit details
-
Copy full SHA for b19810b - Browse repository at this point
Copy the full SHA b19810bView commit details
Commits on Mar 19, 2024
-
Revert "Get rid of extra logic and tests related to InitPlans"
Skip InitPlans, but don't restore a useless test. This reverts commit bb559fd236bda017152005fa8eebfc0b58751695.
Configuration menu - View commit details
-
Copy full SHA for d00b0e3 - Browse repository at this point
Copy the full SHA d00b0e3View commit details