fix wildcard interconnect address type #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
whitehawk
reviewed
Apr 15, 2024
whitehawk
reviewed
Apr 15, 2024
Partially revert 50748b7 changes that broke down wildcard interconnect address type handling for gpdb 7. Removed duplicated assertion, already checked for unicast interconnect few lines above. interconnect_address is null for wildcard address type. In this case service arg of getaddrinfo must not be null, because either node or service may be null according to man page. A unit test for this case provided too.
|
Please start the summary with a capital letter: |
This comment was marked as resolved.
This comment was marked as resolved.
whitehawk
reviewed
Nov 14, 2024
silent-observer
approved these changes
Dec 27, 2024
whitehawk
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wildcard interconnect address type
GPDB used to fail to setup UDP interconnect sockets when
gp_interconnect_address_type GUC was set to wildcard mode. The problem was caused
by passing invalid set of arguments to getaddinfo library function and
consequent getting EAI_NONAME errno. interconnect_address is null for wildcard
address type. In this case service arg of getaddrinfo must not be null, because
either node or service may be null according to man page of getaddrinfo(3).
The mentioned problem was caused by 50748b7. So partially reverted this patch.
Removed duplicated assertion, already checked for unicast interconnect few
lines above.
A unit test for this case is provided too. The default interconnect address
type was explicitly point for existing tests. IPv6 wildcard test was fully
duplicated by existing unicast test and was reworked to test wildcard
configuration. It's expected that Linux returns IPv4 address first for wildcard
request even on machines with IPv6. So, pined it by this test.