[ADH-5332]: Implement support of pushdown functions predicates #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
VitekArkhipov
commented
Nov 27, 2024
VitekArkhipov
commented
- implemented pushdown expression rewriters
- implemented aggregation function rewriters
- reformat code
- fixed jdbc splitting bug
VitekArkhipov
requested review from
Asmoday,
iamlapa,
RomaZe and
tigrulya-exe
iamlapa
approved these changes
Nov 29, 2024
…DH-5332 # Conflicts: # plugin/trino-adb/src/main/java/io/trino/plugin/adb/connector/AdbClientModule.java # plugin/trino-adb/src/main/java/io/trino/plugin/adb/connector/AdbSqlClient.java # plugin/trino-adb/src/main/java/io/trino/plugin/adb/connector/protocol/gpfdist/unload/process/GpfdistCsvDataProcessor.java # plugin/trino-adb/src/main/java/io/trino/plugin/adb/connector/protocol/gpfdist/unload/process/GpfdistRecordCursor.java
tigrulya-exe
reviewed
Dec 3, 2024
plugin/trino-adb/src/main/java/io/trino/plugin/adb/connector/AdbSqlClient.java
Outdated
Show resolved
Hide resolved
...in/trino-adb/src/main/java/io/trino/plugin/adb/connector/aggregation/AdbImplementMinMax.java
Outdated
Show resolved
Hide resolved
plugin/trino-adb/src/main/java/io/trino/plugin/adb/connector/encode/csv/CsvFormatConfig.java
Outdated
Show resolved
Hide resolved
...db/src/main/java/io/trino/plugin/adb/connector/expression/AdbRewriteDatetimeArithmetics.java
Show resolved
Hide resolved
...db/src/main/java/io/trino/plugin/adb/connector/expression/AdbRewriteDatetimeArithmetics.java
Outdated
Show resolved
Hide resolved
VitekArkhipov
changed the base branch from
feature/ADH-5241
to
feature/ADH-5240
# Conflicts: # plugin/trino-adb/src/main/java/io/trino/plugin/adb/connector/AdbSqlClient.java # plugin/trino-adb/src/main/java/io/trino/plugin/adb/connector/protocol/gpfdist/GpfdistModule.java
tigrulya-exe
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.