Skip to content

Commit

Permalink
Expand error message for when fifo is used with GPU locale model (cha…
Browse files Browse the repository at this point in the history
…pel-lang#24620)

With GPU support, we can't use the `fifo` tasking layer. We do have an
error message for that, but for some reason it was just checking it for
cpu-as-device mode. This PR fixes the error message to cover all GPU
configs.

Resolves chapel-lang#24619.

[Reviewed by @ShreyasKhandekar]
  • Loading branch information
e-kayrakli authored Mar 25, 2024
2 parents 4ad2158 + 6c517e9 commit 1dada02
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions util/chplenv/chpl_gpu.py
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,10 @@ def validate(chplLocaleModel):
# (e.g. CUDA or ROCm)
gpu.validate_sdk_version()

if chpl_tasks.get() == 'fifo':
error("The 'fifo' tasking model is not supported with GPU support")

if get() == 'cpu':
if chpl_tasks.get() == 'fifo':
error("The 'fifo' tasking model is not supported with CPU-as-device mode")
return True

if chpl_compiler.get('target') != 'llvm':
Expand Down

0 comments on commit 1dada02

Please sign in to comment.