Guard the iterator check as well

Avoids a failure for test/types/range/elliot/anonymousRangeIter.chpl, presumably because it modifies the generated code just enough to tweak it. ---- Signed-off-by: Lydia Duncan <[email protected]>
arezaii · Feb 16, 2024 · 8bd695d · 8bd695d
1 parent 8d2b8cd
commit 8bd695d
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/compiler/AST/iterator.cpp b/compiler/AST/iterator.cpp
@@ -1847,9 +1847,11 @@ rebuildIterator(IteratorInfo* ii,
 
   fn->insertAtTail(new DefExpr(iterator));
 
-  // Lydia 2/14/24 todo: only do this when we're performing the constness
-  // checks?
-  fn->insertAtTail(new CallExpr(PRIM_ZERO_VARIABLE, new SymExpr(iterator)));
+  // Avoids a valgrind warning about uninitialized memory when performing
+  // indirect modification checks on const and default intent arguments
+  if (fWarnUnstable && !fNoConstArgChecks) {
+    fn->insertAtTail(new CallExpr(PRIM_ZERO_VARIABLE, new SymExpr(iterator)));
+  }
 
   // For each live argument
   forv_Vec(Symbol, local, locals) {