Chapel patch and fix for main #3
Conversation
| @@ -72,8 +72,8 @@ class Chapel(AutotoolsPackage, CudaPackage, ROCmPackage): | |||
|
|
|||
| patch("fix_spack_cc_wrapper_in_cray_prgenv.patch", when="@2.0.0:") | |||
| patch("fix_chpl_shared_lib_path.patch", when="@2.1:2.2 +python-bindings") | |||
| patch("fix_chpl_shared_lib_path_2.3.patch", when="@2.2.1: +python-bindings") | |||
| patch("fix_chpl_line_length.patch") | |||
| patch("fix_chpl_shared_lib_path_2.3.patch", when="@2.2.1:2.3 +python-bindings") | |||
There was a problem hiding this comment.
To ease future maintenance, I'd like to request comments here recording where each defect was fixed, as done for the patches below. i.e. something of the form:
| patch("fix_chpl_shared_lib_path_2.3.patch", when="@2.2.1:2.3 +python-bindings") | |
| patch("fix_chpl_shared_lib_path_2.3.patch", when="@2.2.1:2.3 +python-bindings") # PR 26388 |
and similarly for at least the two surrounding patch lines (the prior patch line is the same PR, I have not tried to track down the PR for the subsequent patch line)
| @@ -72,8 +72,8 @@ class Chapel(AutotoolsPackage, CudaPackage, ROCmPackage): | |||
|
|
|||
| patch("fix_spack_cc_wrapper_in_cray_prgenv.patch", when="@2.0.0:") | |||
| patch("fix_chpl_shared_lib_path.patch", when="@2.1:2.2 +python-bindings") | |||
There was a problem hiding this comment.
Have you tested the updated patch against [email protected]?
There was a problem hiding this comment.
the python-bindings variant isn't actually available until 2.2, so maybe this can/should be revised to @2.1.1:2.2?
There was a problem hiding this comment.
maybe this can/should be revised to
@2.1.1:2.2?
Sounds reasonable to me.
I was mostly worried about validating the patch applies cleanly.
Goal here is to fix bugs with main, incorporate patch for setting the python shared library rpath