Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update moltres contact #250

Merged
merged 5 commits into from
Mar 1, 2022
Merged

Update moltres contact #250

merged 5 commits into from
Mar 1, 2022

Conversation

smpark7
Copy link
Contributor

@smpark7 smpark7 commented Mar 1, 2022

Summary of changes

This PR updates broken links, installation instructions, and contact information on the moltres webpage.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Associated Issues and PRs

Associated Developers

  • Dev: @

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

@smpark7 smpark7 requested a review from abachma2 March 1, 2022 18:22
@smpark7 smpark7 self-assigned this Mar 1, 2022
abachma2
abachma2 reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@abachma2 abachma2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. I have requested a few small changes that I think help clean and clear things up. Good work.

software/moltres/moltres.md Outdated Show resolved Hide resolved
software/moltres/moltres.md Outdated Show resolved Hide resolved
software/moltres/moltres.md Show resolved Hide resolved
smpark7 added a commit to smpark7/moltres that referenced this pull request Mar 1, 2022
@smpark7
Incorporate changes made in arfc/arfc.github.io#250
355efb4
abachma2
abachma2 approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@abachma2 abachma2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. I am approving and merging this PR.

@abachma2 abachma2 merged commit 1a7adb7 into arfc:source Mar 1, 2022
osanstrong pushed a commit to osanstrong/arfc.github.io that referenced this pull request Jul 11, 2024
@abachma2
Merge pull request arfc#250 from smpark7/update-moltres-contact
cb98da2 
Update moltres contact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abachma2 abachma2 abachma2 approved these changes

Assignees

@smpark7 smpark7

Labels
Comp:Core Difficulty:1-Beginner Priority:2-Normal Status:5-In Review Type:Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smpark7 @abachma2