-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update group publications display #322
Conversation
…eed conference proceedings where available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this up @osanstrong! I have a few comments. I think there are two main things to think about, and @katyhuff may have to help you answer them:
- Are the things in the refrences.bib file relevant to the group? They definitely involve the group or members of the group in some way, but was the work done in the group?
- Does Prof. Huff want items from her time at DOE on the website?
gidden_agent-based_2013.pdf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this file get moved up a directory for some reason?
papers/ashraf_preliminary_2021.pdf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we trying to add prelims to the website @katyhuff? I don't think those are typically public but it's your group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notably, the ashraf preliminary paper is not a prelim. It's a journal article whose first word is "Preliminary".
_bibliography/references.bib
Outdated
} | ||
|
||
@phdthesis{yardas_implementation_2023, | ||
type = {Thesis}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type = {Thesis}, | |
type = {Masters Thesis}, | |
There is something like this (this may not be exactly it) you can add it to tell bibtex this is an MS thesis, or else it assumes a PhD thesis.
_bibliography/references.bib
Outdated
journal = {Progress in Nuclear Energy}, | ||
author = {Bae, Jin Whan and Singer, Clifford E. and Huff, Kathryn D.}, | ||
month = jul, | ||
y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @
here is red in the GitHUb diff. Can you check the syntax to make sure that isn't an issue here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's odd; I'll see if I can figure out why the diff highlighter thinks it's an error, but I just checked and these entries are still processed and appear on the website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't fully identify what it was about them, but a few entries had large abstracts which, with linebreaks in them, prevented github's syntax highlighting from recognizing the end of the field (Whatever it was didn't seem to affect the website or vim parsing it properly); removing the linebreaks from these specific entries seems to have mostly fixed the syntax highlighting in the diff.
_bibliography/references.bib
Outdated
volume = {114}, | ||
issn = {0149-1970}, | ||
url = {http://www.sciencedirect.com/science/article/pii/S014919701930037X}, | ||
doi = {10.1016/j.pnucene.2019.02.001}, | ||
abstract = {The French 2012–2015 Commission Nationale d’Evaluation Reports emphasize preparation for a transition from Light Water Reactors (LWRs) to Sodium-Cooled Fast Reactors (SFRs). We used the Cyclus nuclear fuel cycle simulator to explore the feasibility of enabling a French transition to an SFR fleet by using Used Nuclear Fuel (UNF) from other European Union (EU) nations. A Cyclus simulation captured nuclear power deployment in the EU from 1970 to 2160. In this simulation, France begins its planned transition to SFRs as existing LWRs are decommissioned. These SFRs are fueled with UNF accumulated by other EU nations and reprocessed in France. The impact of reactor lifetime extensions and SFR breeding ratios on time-to-transition were investigated with additional simulations. These simulations demonstrate that France can avoid deployment of additional LWRs by accepting UNF from other EU nations, that lifetime extensions delay time-to-transition, and improved breeding ratios are not particularly impactful.}, | ||
urldate = {2019-04-15}, | ||
journal = {Progress in Nuclear Energy}, | ||
author = {Bae, Jin Whan and Singer, Clifford E. and Huff, Kathryn D.}, | ||
month = jul, | ||
y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katyhuff, do you want this one in here? This seems like an "official DOE" thing. There might be a couple more that fit under this catagory in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @abachma2 -- whichever thing you commented on is no longer where it was, so I don't know which paper you meant to reference with this comment (I believe this is because @osanstrong had to revert some commits).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things did get moved around. The broad question here is if you want items from your time at DOE on this website, since you were on an official leave of absence from the university. I think 2 examples of this are lines 2960-3024.
_bibliography/references.bib
Outdated
author = {Bae, Jin Whan and Singer, Clifford E. and Huff, Kathryn D.}, | ||
month = jul, | ||
y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an MS or PHD thesis
_bibliography/references.bib
Outdated
@article{bae_synergistic_2019, | ||
title = {Synergistic spent nuclear fuel dynamics within the {European} {Union}}, | ||
volume = {114}, | ||
issn = {0149-1970}, | ||
url = {http://www.sciencedirect.com/science/article/pii/S014919701930037X}, | ||
doi = {10.1016/j.pnucene.2019.02.001}, | ||
abstract = {The French 2012–2015 Commission Nationale d’Evaluation Reports emphasize preparation for a transition from Light Water Reactors (LWRs) to Sodium-Cooled Fast Reactors (SFRs). We used the Cyclus nuclear fuel cycle simulator to explore the feasibility of enabling a French transition to an SFR fleet by using Used Nuclear Fuel (UNF) from other European Union (EU) nations. A Cyclus simulation captured nuclear power deployment in the EU from 1970 to 2160. In this simulation, France begins its planned transition to SFRs as existing LWRs are decommissioned. These SFRs are fueled with UNF accumulated by other EU nations and reprocessed in France. The impact of reactor lifetime extensions and SFR breeding ratios on time-to-transition were investigated with additional simulations. These simulations demonstrate that France can avoid deployment of additional LWRs by accepting UNF from other EU nations, that lifetime extensions delay time-to-transition, and improved breeding ratios are not particularly impactful.}, | ||
urldate = {2019-04-15}, | ||
journal = {Progress in Nuclear Energy}, | ||
author = {Bae, Jin Whan and Singer, Clifford E. and Huff, Kathryn D.}, | ||
month = jul, | ||
y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really not sure @katyhuff wants this one in the group publications 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @abachma2 -- whichever thing you commented on is no longer where it was, so I don't know which paper you meant to reference with this comment (I believe this is because @osanstrong had to revert some commits).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was in reference to a news article about Dr. Huff being banned from entry into Russia because of her position in the US Executive Branch. The item is now at line 3820.
_bibliography/references.bib
Outdated
month = jul, | ||
y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was a seminar at UTK, which I think should be the address, and not UIUC.
_bibliography/references.bib
Outdated
journal = {Progress in Nuclear Energy}, | ||
author = {Bae, Jin Whan and Singer, Clifford E. and Huff, Kathryn D.}, | ||
month = jul, | ||
y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another one with a red @
I will discuss publication relevancies again with Professor Huff; Correct, the latest list was publications which were by ARFC members (as members) or the group as a whole. This can definitely be revised, especially in regards to file uploads before merging anything. As for the MS/PHD thesis differentiation, I'll go through the theses on Zotero and make sure that distinction is present. |
…ection in abstract of ridley_preliminary_2017 which was confusing syntax highlighters
…interfered with github syntax highlighting
@katyhuff
|
Thanks for the question @osanstrong .
I don't think these need to be a priority unless they are "referreed conference proceedings".
It does not matter how many collaborators are on the paper. Articles on which an ARFC member was a co-author while they were in the group should be included.
I'm not sure I understand this question.
No |
6d18b69
to
dbbe8f3
Compare
I just removed the pdfs from the books/book chapters (5 Files). @katyhuff Just to check again, are we including papers which were from your time at the DOE/leave of absence from UIUC? I recall the answer being yes, but wanted to check since it wasn't answered in writing. Other than that, I think this should address the comments from July, and should be ready for one last review. Should I ask Nathan or any other grad students to check it out? (I can also quadruple check for papers from times where the author was not an ARFC member, when I get a chance) |
Yes, I think it's fine to include papers from the DOE times. |
@katyhuff Thank you! |
Summary of changes
This PR updates the website's bibliography to include missing publications, and adds select PDFs of journal articles, refereed conference proceedings, and book chapters.
On creation (first two commits), this PR mimics the changes of #313 , in a new branch untainted with revised/removed pdf uploads.
Types of changes
Associated Issues and PRs
Associated Developers
Checklist for Reviewers
Reviewers should use this link to get to the
Review Checklist before they begin their review.