Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes PrecursorAction with velocity functions, and supports higher order precursor variable initialization #266

Merged
merged 11 commits into from
Feb 13, 2025

Conversation

smpark7
Copy link
Collaborator

@smpark7 smpark7 commented May 10, 2024

Fixes #183. Fixes #265.

Description

PrecursorAction allows users to define their velocity values for delayed neutron precursor advection using constants, mathematical functions, or MOOSE variables. However, using velocity functions had limited scope due to bugs described in #183. With this PR, PrecursorAction will fully support modeling precursor flow with velocity functions (in line with existing functionality with constant or coupled velocity values).

This PR also extends support for modeling precursor variables with higher (>0) order discontinuous variables.

Changes

  • New PrecursorAction Enum input parameter velocity_type to indicate whether the velocity components are constant, function, or variable
    • Replaces the old constant_velocity_values bool-type parameter
  • New SideFunctionWeightedIntegralPostprocessor to calculate precursor outflow at the outlet when using velocity functions
  • Edits in PrecursorAction:
    • Check whether users provided the correct type of velocity parameters
    • Initialize precursor advection kernels when using higher order variables
    • Initialize penalty boundary conditions to suppress unphysical numerical oscillations at the inlet near the wall
    • Correctly calculate the outflow precursor concentration when using velocity functions
  • New & updated tests for precursor flow modeling with velocity functions and first order variables.
  • Update squirrel submodule for PostprocessorVelocityFunctionInflowBC, VelocityFunctionConservativeAdvection, & PostprocessorPenaltyDirichletBC objects required in this bugfix.
  • Update MOOSE submodule for general updates
  • Fix tests in moltres/problems/2021-cnrs-benchmark/phase-0 which were checking the wrong input file

Impact

  • Users can now use velocity functions when modeling precursor flow with core reentry
  • Users can now use higher (>0) order precursor variables
  • New features/updates from the MOOSE submodule update

@smpark7 smpark7 changed the title [WIP] Fix PrecursorAction with velocity functions, and support higher order precursor variable initialization [WIP] Fixes PrecursorAction with velocity functions, and support higher order precursor variable initialization May 10, 2024
@smpark7 smpark7 requested review from LukeSeifert and yardasol and removed request for LukeSeifert and yardasol May 10, 2024 21:21
@smpark7 smpark7 self-assigned this May 10, 2024
@smpark7 smpark7 changed the title [WIP] Fixes PrecursorAction with velocity functions, and support higher order precursor variable initialization Fixes PrecursorAction with velocity functions, and support higher order precursor variable initialization May 13, 2024
@smpark7 smpark7 changed the title Fixes PrecursorAction with velocity functions, and support higher order precursor variable initialization Fixes PrecursorAction with velocity functions, and supports higher order precursor variable initialization May 13, 2024
Copy link
Collaborator

@nglaser3 nglaser3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good! I've added a few small comments throughout.

@katyhuff
Copy link
Member

@smpark7 , what's the status of this one?

@smpark7
Copy link
Collaborator Author

smpark7 commented Aug 19, 2024

I need to address nathan's comments and rerequest reviews. I'll get on it this week

@smpark7
Copy link
Collaborator Author

smpark7 commented Feb 12, 2025

@nglaser3 I addressed your review comments and shortened the pre_loop_ins test because it was getting timed out by CIVET for taking more than 600s to run.

@smpark7 smpark7 requested a review from nglaser3 February 12, 2025 23:47
Copy link
Collaborator

@nglaser3 nglaser3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass, and all changes look good to me!

@nglaser3 nglaser3 merged commit f57d6e3 into arfc:devel Feb 13, 2025
2 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 13, 2025
Fixes PrecursorAction with velocity functions, and supports higher order precursor variable initialization f57d6e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants