-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes PrecursorAction with velocity functions, and supports higher order precursor variable initialization #266
Conversation
… tests for time-varying flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good! I've added a few small comments throughout.
@smpark7 , what's the status of this one? |
I need to address nathan's comments and rerequest reviews. I'll get on it this week |
…IntegralPostprocessor
@nglaser3 I addressed your review comments and shortened the pre_loop_ins test because it was getting timed out by CIVET for taking more than 600s to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests pass, and all changes look good to me!
Fixes PrecursorAction with velocity functions, and supports higher order precursor variable initialization f57d6e3
Fixes #183. Fixes #265.
Description
PrecursorAction
allows users to define their velocity values for delayed neutron precursor advection using constants, mathematical functions, or MOOSE variables. However, using velocity functions had limited scope due to bugs described in #183. With this PR, PrecursorAction will fully support modeling precursor flow with velocity functions (in line with existing functionality with constant or coupled velocity values).This PR also extends support for modeling precursor variables with higher (>0) order discontinuous variables.
Changes
PrecursorAction
Enum input parametervelocity_type
to indicate whether the velocity components areconstant
,function
, orvariable
constant_velocity_values
bool-type parameterSideFunctionWeightedIntegralPostprocessor
to calculate precursor outflow at the outlet when using velocity functionsPrecursorAction
:PostprocessorVelocityFunctionInflowBC
,VelocityFunctionConservativeAdvection
, &PostprocessorPenaltyDirichletBC
objects required in this bugfix.moltres/problems/2021-cnrs-benchmark/phase-0
which were checking the wrong input fileImpact