-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
U.S. transition scenario (2013-2160) #83
base: master
Are you sure you want to change the base?
Conversation
conflicts. ^ |
This PR is way too big for me to review in a timely manner. Can you perhaps request a review from a colleague and then walk that colleague through the PR to facilitate the review? That is, perhaps @gwenchee @gtw2 or @robfairh would be willing to sit with you and look over this, and perhaps they would be helped by you walking through the highlights of the PR? |
I could look over this with you tomorrow @jbae11 |
Perhaps, since |
The input files that are generated from the jupyter notebook requires some modifications (in XInclude), so it's probably best to include the xml files |
Is there no way to modify them within the jupyter notebook? @jbae11 |
I think that'd be very complex. |
I entirely agree with gwen on this one. From a reproducibility standpoint, you either need to fully document the creation process for the xml files, or automate their creation. |
Status of this? |
@jbae11 ping. |
@jbae11 What is the status of this? |
This PR includes U.S. transition scenario cyclus input where
the U.S. transitions into a MSR fleet starting 2050.