Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U.S. transition scenario (2013-2160) #83

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Conversation

jbae11
Copy link
Collaborator

@jbae11 jbae11 commented Oct 25, 2018

This PR includes U.S. transition scenario cyclus input where
the U.S. transitions into a MSR fleet starting 2050.

@katyhuff
Copy link
Member

conflicts. ^

@jbae11
Copy link
Collaborator Author

jbae11 commented Oct 25, 2018

@katyhuff it conflicts becuase of write_input.py, which is removed by #84 . Once #84 is merged it should not conflict anymore.

@katyhuff
Copy link
Member

katyhuff commented Nov 2, 2018

This PR is way too big for me to review in a timely manner.

Can you perhaps request a review from a colleague and then walk that colleague through the PR to facilitate the review? That is, perhaps @gwenchee @gtw2 or @robfairh would be willing to sit with you and look over this, and perhaps they would be helped by you walking through the highlights of the PR?

@gwenchee
Copy link
Contributor

gwenchee commented Nov 4, 2018

I could look over this with you tomorrow @jbae11

@gwenchee
Copy link
Contributor

gwenchee commented Nov 5, 2018

Perhaps, since get_input_file.ipynb generates the xml input files, you don't need to include the xml input files in the PR? And just have clear instructions in the notebooks about how to generate the input files?

@jbae11
Copy link
Collaborator Author

jbae11 commented Nov 6, 2018

The input files that are generated from the jupyter notebook requires some modifications (in XInclude), so it's probably best to include the xml files

@gwenchee
Copy link
Contributor

Is there no way to modify them within the jupyter notebook? @jbae11

@jbae11
Copy link
Collaborator Author

jbae11 commented Nov 20, 2018

I think that'd be very complex.

@katyhuff
Copy link
Member

I entirely agree with gwen on this one. From a reproducibility standpoint, you either need to fully document the creation process for the xml files, or automate their creation.

@katyhuff
Copy link
Member

katyhuff commented Jan 2, 2019

Status of this?

@katyhuff
Copy link
Member

katyhuff commented Mar 8, 2019

@jbae11 ping.

@katyhuff
Copy link
Member

@jbae11 What is the status of this?

@katyhuff
Copy link
Member

@jbae11 I just wanted to ping you to see if you have any interest in handilng these conflicts to allow this to be merged. I just bring this up because we're near merging another PR (from @abachma2 ) that will cause significantly more conflicts in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants