Rename claim --> gift #46
Conversation
scripts/profile.ts
Outdated
| const { txReceipt, gift, giftPrivateKey } = await defaultDepositTestSetup({ | ||
| factory, | ||
| useTxV3, | ||
| overrides: { | ||
| claimPrivateKey: 42n, | ||
| giftTokenAddress: giftTokenContract.address, | ||
| }, | ||
| }); | ||
|
|
||
| const { claim: claimExternalOj, claimPrivateKey: claimPrivateKeyExternal } = await defaultDepositTestSetup({ | ||
| factory, | ||
| useTxV3, | ||
| overrides: { | ||
| claimPrivateKey: 43n, |
There was a problem hiding this comment.
Removing this broke the profiler ^^'
There was a problem hiding this comment.
(You gotta make 2 gifts to be able to profile claim and claim external)
Co-authored-by: gaetbout <[email protected]>
|
God this is painful to review 🤣 |
| /// @param factory The address of the factory | ||
| /// @param class_hash The class hash of the gift account | ||
| /// @param class_hash The class hash of the escrow account | ||
| /// @param sender The address of the sender | ||
| /// @param gift_token The ERC-20 token address of the gift |
There was a problem hiding this comment.
Unrelated but this sentence ins't clear to me
There was a problem hiding this comment.
Ignore it but let's keep it in mind later when we review doc
| self: @TContractState, | ||
| class_hash: ClassHash, | ||
| escrow_class_hash: ClassHash, |
There was a problem hiding this comment.
to stay consistent, should we use the same naming as in deposit?
| escrow_class_hash: ClassHash, | |
| escrow_class_hash: ClassHash, |
if y, take care to update the doc plz
There was a problem hiding this comment.
i dont get it dont they have the same name?
There was a problem hiding this comment.
Wtf was my vscode doing '-'
You can close this remark x)
|
Banger branch name btw |
Claim --> gift
starknet_gifting -> argent_gifting
account --> escrow account
account impl --> library
didnt touch asserts yet!