fix: update starknetkit to be compatible with starknet-react v3 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
waiting for #104 to be merged for argent mobile compatibility |
| @@ -116,7 +116,7 @@ export const StarknetMethodArgumentsSchemas = { | |||
| z | |||
| .object({ | |||
| starknetVersion: z | |||
| .union([z.literal("v3"), z.literal("v4")]) | |||
| .union([z.literal("v3"), z.literal("v4"), z.literal("v5")]) | |||
There was a problem hiding this comment.
Why do we need v3 here?
There was a problem hiding this comment.
kept it for backward compatibility
but with rpc wallet snip and this version of starknetkit it could be probably removed (since with this version the old methods -- like enable -- won't be used anymore)
There was a problem hiding this comment.
don't we need v6 as well here?
There was a problem hiding this comment.
this is related to the enable function only
with v6
this.request({
type: "wallet_requestAccounts",
})will be used
So probably it would makes sense to remove this part?
@dhruvkelawala @vladutjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.