fix: webwallet trpc link for popups #164
Conversation
|
|
||
| // Monitor popup state | ||
| const checkClosed = setInterval(() => { | ||
| if (popup.closed) { |
There was a problem hiding this comment.
What if popup.closed === true but this.currentPopup !== popup, aka we got another popup 🤔
I'm just thinking of the possible corner case here, not stating that is an issue
There was a problem hiding this comment.
could be an edge case, but theoretically this.currentPopup !== popup should not happen in this case
popup is always the new one
thinking if this approach could be more reliable but it would requires some tests (using beta branch)
| button.style.position = "fixed" | ||
| button.style.top = "-999px" | ||
| button.style.left = "-999px" | ||
| button.style.opacity = "0" | ||
| button.style.pointerEvents = "none" // prevent click event |
There was a problem hiding this comment.
Are these styles making any difference from the previously used webwalletBtn.style.display = "none"?
There was a problem hiding this comment.
did some searching and it seems it's more reliable
- Browser Security: Some browsers treat elements with display: none as "not truly interactive" from a security perspective, which can affect how they handle popup permissions
- DOM Interaction: While display: none removes the element from the layout flow completely, position: fixed keeps it in the DOM's interactive layer
- Mobile Browsers: Particularly on mobile browsers, clicks on display: none elements might be ignored or treated differently than clicks on positioned-but-invisible elements
There was a problem hiding this comment.
Interesting. I saw something like this coming, legit 👍🏼
Issue / feature description
Quick description of the issue or the feature that is implemented in the pr ie: add new transitions between screensChanges
quick list regarding the related changes within the prie:
Checklist
Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.
Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.