Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts build errors #178

Merged
merged 3 commits into from
Jan 6, 2025
Merged

fix: ts build errors #178

merged 3 commits into from
Jan 6, 2025

Conversation

bluecco
Copy link
Contributor

@bluecco bluecco commented Jan 6, 2025

Issue / feature description

Quick description of the issue or the feature that is implemented in the pr ie: add new transitions between screens

Changes

quick list regarding the related changes within the pr

ie:

  • add new connector
  • fix injected connector
  • ...

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.

Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.

@dhruvkelawala
Copy link
Contributor

Should also add eslint rule here, so that it fixes itself on save.

@typescript-eslint/consistent-type-imports: "error"

@bluecco bluecco merged commit a717f32 into develop Jan 6, 2025
1 check passed
@bluecco bluecco deleted the fix/build-errors branch January 6, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants