Support custom default headers in OpenAILLM class.
#1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidberenstein1957
approved these changes
Jan 8, 2025
|
@khulaifi95 could you resolve the merge conflicts? After we can merge :) |
|
@gabrielmbmb Hi Gabriel, thanks for helping the merge. I realised that there were conflicts because my commits were on the forked main branch, but the target was set to be the develop branch. Thank you for solving this :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this is my first PR on github. I added header customisation to the
OpenAILLMgeneric inference class for interacting with OpenAI compatible servers.This would be useful if the server is privately hosted behind a gateway or proxy, where metadata such as model provider or cloud provider is required to authenticate the request.
The parameter is passed directly to both internal OpenAI clients. The simple test case is added.