Update generate_prompt in Task subclasses to always return Prompt
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including both fixes within the examples themselves, and also w.r.t. the recent removal of the `Llama2TextGenerationTask`
…e_prompt` Since the default prompt format will be applied within `Prompt` if not format is specified, and it implies joining both the `system_prompt` and `formatted_prompt` with a line-break, then the leading line-break is not needed within the `formatted_prompt`
gabrielmbmb
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that all the methods
generate_promptdefined within the abstract classTask, return aPromptwith no formatting, as the formatting is handled internally by thePromptvia theformat_asmethod, which is used by the user via the argprompt_formatwithin eachLLM. This way, we ensure that theTaskimplementations are LLM-agnostic, meaning that any task format can be used with any LLM.So on, the above implies that both
OpenAITextGenerationTaskandLlama2TextGenerationTaskhave been removed too, as those were constrained to the formatting of an LLM, in particular OpenAI and Llama2, respectively.Closes #186