-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 230 feature add sentence transformers support for the to argilla method #262
feat: 230 feature add sentence transformers support for the to argilla method #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, this will be so useful! Some pictures of the UI would be nice once we add the docs, just to keep it in mind
…upport-for-the-to_argilla-method
src/distilabel/tasks/base.py
Outdated
from distilabel.utils.imports import _ARGILLA_AVAILABLE | ||
|
||
if _ARGILLA_AVAILABLE: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from distilabel.utils.imports import _ARGILLA_AVAILABLE | |
if _ARGILLA_AVAILABLE: | |
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has no effect currently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small notes, looks nice, will be really helpful 😄
@plaguss I now added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming looks fine to me 😄
I added
sentence-transformers
support to theto_argilla
methods.Things to note:
add_vectors_to_argilla_dataset
to theTask
base classvector_strategy
argument to theto_argilla
methods. This can either be a bool or aSentenceTransformersExtractor
and default to True. If True, it uses the defaults. if False, it does nothing, if SentenceTransformersExtractor it will use a custom-initialized extractor.sentence-transformers
to theargilla
extras to avoid having more splits in this and to align with using this as default.1.22.0
because this is required for theSentenceTransformersExtractor
WIP: