-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add customizable criteria for query generation in SelfInstructTask #269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! just the small comment to keep the original template intact by default
Co-authored-by: Agus <[email protected]>
…nto feat/flexibility_selfinstruct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@ignacioct @plaguss, for me now it is only implicitly possible to change these values but we don't provide any clear insights in the docs or pointers as to how to do that. Also, we need to make a reference to it within the docs.
@ignacioct maybe you can also add references or mention the jinaj2 templates when you tackle the customising task templates issue w.r.t. the documentation. |
@davidberenstein1957 I've added the docstring and docs changes, please tell me if we need further documentation |
I'll do :) |
Just some extra addition to the docs and done |
Ready for final review, and we can push @plaguss @davidberenstein1957 |
@ignacioct , can you add the custom task snippet(s) in another PR? |
Do you mean to remove the case of the |
Closes #255 suggested by @davanstrien
I've tried with https://github.com/davanstrien/haiku-dpo/blob/main/01_generate_haiku_prompts.ipynb and works fine. I've updated the documentation with a generic example instead of a Haiku example, to be more consistent with the rest of the snippets, which are very generic. We could do a tutorial with some use cases, like the Haiku, to show off this new feature.
Thanks, @dvsrepo and @plaguss for showing me the way 💡