-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Argilla
integration TextGeneration
, Preference
, and more
#472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarobartt
commented
Mar 26, 2024
plaguss
reviewed
Mar 26, 2024
gabrielmbmb
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
plaguss
approved these changes
Mar 26, 2024
Co-authored-by: Gabriel Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
PreferenceToArgilla
step that will basically push a dataset to Argilla for preference i.e. rating and rationale over a list of generated responses for a given instruction. ThePreferenceToArgilla
step works with both existing suggestions i.e.ratings
andrationales
and injects those as suggestions within each record, but is also helpful for datasets that want to be hand annotated by humans with no suggestions i.e. noratings
andrationales
. Additionally, note that this task provides a seamless integration withUltraFeedback
so that's easier than ever to upload theUltraFeedback
generated and annotated data to Argilla.Also some minor tweaks and improvements have been applied to
PromptCompletionToArgilla
renamed toTextGenerationToArgilla
.Besides that, this PR also adds the
KeepColumn
step which basically is useful for column sorting and filtering before thepipeline.run
ends, and I found it very convenient when running diverse pipelines with unsorted outputs and producing more columns that the ones I wanted, soKeepColumns
helps with that and also respects the order provided via thecolumns
arg.Additionally, also the docstrings have been fixed and aligned for both
CombineColumns
andKeepColumns
, as well as adding the unit tests for both steps. Finally, this PR also runscodespell
to fix some typos in the codebase.Example