-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep track of residuals in IterState
, adapted GaussNewton
accordingly
#343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work, I really appreciate it! Changes like these are quite a chore! I have only a few minor comments. Unfortunately the changes I am requesting are also a lot of chore :/
Feel free to get in touch if something isn't clear.
@@ -89,7 +89,7 @@ where | |||
} | |||
} | |||
|
|||
impl<P, O, F> Solver<O, IterState<P, (), (), (), F>> for ConjugateGradient<P, F> | |||
impl<P, O, F, R> Solver<O, IterState<P, (), (), (), F, R>> for ConjugateGradient<P, F> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CG actually has residuals. Updating this to use the residual in IterState
could be a good additional test bed, but it can also be skipped for this PR.
Yup, I think I get it all. I have it in progress. Unfortunately I'll be offline until mid-next-week, FYI. |
Are you on Windows? Tests require |
I tried to fix the conflicts with |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
- Coverage 90.25% 90.23% -0.02%
==========================================
Files 141 141
Lines 19679 19778 +99
==========================================
+ Hits 17761 17847 +86
- Misses 1918 1931 +13 ☔ View full report in Codecov by Sentry. |
…es throughout the codebase
IterState
, adapted GaussNewton
accordingly
I took a stab at updating the definition of IterState to support a fix for #342. Library builds. Tests likely don't build. I currently don't have the ability to build the tests.