Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to make ingress class name configurable #51

Open
wants to merge 1 commit into
base: v0.6.4
Choose a base branch
from

Conversation

guptaankit015
Copy link
Contributor

No description provided.

@suryaoruganti
Copy link
Contributor

The changes are fine.
However, Kong etc. require annotations on service objects for some configurations iirc.
Currently, services do not support annotations in the helm chart.
Something similar to this will need to be added
https://github.com/argonautdev/charts/blob/conf_ing_class/charts/stateless/templates/deployment.yaml#LL26C1-L29C15

@guptaankit015
Copy link
Contributor Author

The changes are fine. However, Kong etc. require annotations on service objects for some configurations iirc. Currently, services do not support annotations in the helm chart. Something similar to this will need to be added https://github.com/argonautdev/charts/blob/conf_ing_class/charts/stateless/templates/deployment.yaml#LL26C1-L29C15

We can add more logic based on the ingressClassName value in different object based on the different types that we will support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants