add libthapi-ctl to start/stop collecting #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bd4
commented
May 31, 2024
bd4
commented
- for opencl backend, separates bookkeeping calls so they stay enabled even when client stops collection
- other backends will be fragile, making some API calls that do bookkeeping while collection is stopped may break things
|
Basic functionality works, and opencl should be robust. Needs better test, documentation, other backends to split out bookkeeping events. |
|
You need to add |
bd4
force-pushed
the
pr/start-stop
branch
3 times, most recently
from
6a369f2 to
5cd0c70
Compare
|
Maybe you just have |
bd4
force-pushed
the
pr/start-stop
branch
3 times, most recently
from
0905910 to
870abfd
Compare
bd4
force-pushed
the
pr/start-stop
branch
2 times, most recently
from
38b5143 to
57ba963
Compare
bd4
force-pushed
the
pr/start-stop
branch
3 times, most recently
from
cb74858 to
dd06771
Compare
- has two function, thapi_start_tracing, thapi_stop_tracing - requires liblttng-ctl - adds iprof option --(no)-profile-from-start, default profile from start - puts events in two different sessions, 'main' and 'bookkeeping', each in it's own subdir - start/stop affect the main session only, bookkeeping is always enabled - so far only opencl backend separates out bookkeeping events; other backends put everything in main (TODO)
- Uses env var, default is 1=ERROR - 0=disabled, 2=WARN, 3=INFO, 4=DEBUG - Under the default log level, no message will be printed when THAPI_LTTNG_SESSION_ID is not set (application is linked with libthapi-ctl and calls start or stop tracing, but not run with iprof).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.