Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MPI / Ci debug #234

Merged
merged 38 commits into from
Jun 5, 2024
Merged

Fix MPI / Ci debug #234

merged 38 commits into from
Jun 5, 2024

Conversation

TApplencourt
Copy link
Collaborator

No description provided.

@TApplencourt TApplencourt requested review from bd4 and Kerilk June 4, 2024 18:11
@TApplencourt
Copy link
Collaborator Author

Log of change (sadly) but the most important:

  • Add new THAPI_UUID (so people can manually set some UUID, even if their MPI env doesn't set it... Like in the github Action)
  • Fix Finalization (called every time)
  • New logic to ensure THAPI_UUID is set
  • Better logging

@TApplencourt TApplencourt mentioned this pull request Jun 4, 2024
Closed
bd4
bd4 previously approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@bd4 bd4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, would appreciate a few comments around the sync daemon finalize magic, but I don't think that is a blocker.

xprof/xprof.rb.in Show resolved Hide resolved
xprof/xprof.rb.in Show resolved Hide resolved
@bd4 bd4 self-requested a review June 5, 2024 21:38
@TApplencourt TApplencourt merged commit f69c613 into master Jun 5, 2024
20 checks passed
@TApplencourt TApplencourt deleted the ci_debug branch June 5, 2024 21:43
TApplencourt added a commit that referenced this pull request Jun 11, 2024
@TApplencourt
Fix MPI / Ci debug (#234)
270ce30
TApplencourt added a commit that referenced this pull request Jun 11, 2024
@TApplencourt
Merge (#238)
e0a3363 
* Fix MPI  / Ci debug (#234)

* at_exit (#236)

* at_exit
* cuda
* simplify
---------
Co-authored-by: Thomas Applencourt <[email protected]>

* Fix non imm (#237)

* fix non imm bug

* clang-format

---------

Co-authored-by: Thomas Applencourt <[email protected]>

---------

Co-authored-by: Thomas Applencourt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bd4 bd4 bd4 approved these changes

@Kerilk Kerilk Awaiting requested review from Kerilk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TApplencourt @bd4