Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sampling: add missing lttng-ust dep #246

Merged
merged 1 commit into from
Jul 1, 2024
Merged

sampling: add missing lttng-ust dep #246

merged 1 commit into from
Jul 1, 2024

Conversation

bd4
Copy link
Collaborator

@bd4 bd4 commented Jul 1, 2024

No description provided.

@bd4 bd4 requested a review from TApplencourt July 1, 2024 16:49
@TApplencourt TApplencourt requested a review from Kerilk July 1, 2024 17:18
@TApplencourt
Copy link
Collaborator

TApplencourt commented Jul 1, 2024 •
edited
Loading

Pinging brice for double checking but LGTM

@bd4
Copy link
Collaborator Author

bd4 commented Jul 1, 2024

The dependency is not obvious, but the generated sampling.h does do #include <lttng/tracepoint.h>, so fails to compile unless lttng is in include path. Easy to miss when lttng is installed in /usr/include.

@Kerilk Kerilk merged commit ef10aa1 into argonne-lcf:master Jul 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TApplencourt TApplencourt TApplencourt approved these changes

@Kerilk Kerilk Kerilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bd4 @TApplencourt @Kerilk