Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non events not used by interval #252

Closed
wants to merge 2 commits into from

Conversation

TApplencourt
Copy link
Collaborator

In the default mode, remove the events not used by interval.

  • If not, they are passed around and finish to be written to disk with the aggregated events.
  • Then, during the replay, with it a file limits.

Of course, this is not a fix for the file limits but just a "cleaning" so that by default we just generate events that we use for the tally / interval.

At term, we should allow user to specify events to enable/disable, and find a real solution for the file limits (smarted use of --source or tree reduction)

@TApplencourt TApplencourt requested a review from Kerilk July 9, 2024 16:38
@Kerilk
Copy link
Collaborator

Kerilk commented Jul 10, 2024

Shouldn't the interval drop events by default instead? after cl_interval there shouldn't be any OpenCL event left in the trace.

@TApplencourt
Copy link
Collaborator Author

Yeah, I was thinking we could do that, too. We cannot do for interval (as they are chained), but we can do that for aggreg. Or create a new plugins who drop everything who is not interval and put it as the end of the chain of interval.

T the advantage that it may help timeline but if people want the timeline they will it the 2GB of protobuf before the number of file open :)

@TApplencourt TApplencourt deleted the remove_not_used_event_for_analsys branch July 12, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants