Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent wrapping unsupported version of CUDA functions. #272

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Prevent wrapping unsupported version of CUDA functions. #272

merged 1 commit into from
Jul 30, 2024

Conversation

Kerilk
Copy link
Collaborator

@Kerilk Kerilk commented Jul 26, 2024

To discuss.

@TApplencourt
Copy link
Collaborator

LGTM!
No sure if we need to escape the \ or \n or not

@TApplencourt
Copy link
Collaborator

The \ doesn't show up

THAPI: CUDA version 12020 is unsupported, could not wrap cuMemPrefetchAsync symbol

So I guess we are good.

One of the problem, is that it may break the analysis (for example if don't wrap cuModuleLoad or whatever)

@bd4
Copy link
Collaborator

bd4 commented Jul 30, 2024

Is this for when the runtime lib version is newer than the version used at build time?

@TApplencourt
Copy link
Collaborator

Exactly! IE when we didn't update the header in THAPI

@Kerilk Kerilk force-pushed the cuda-passthrough branch from ef78bd8 to 9be9048 Compare July 30, 2024 20:41
@Kerilk Kerilk merged commit 7d75979 into master Jul 30, 2024
16 checks passed
@TApplencourt TApplencourt deleted the cuda-passthrough branch July 30, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TApplencourt TApplencourt TApplencourt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kerilk @TApplencourt @bd4