Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenCL Start #280

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Fix OpenCL Start #280

merged 4 commits into from
Aug 29, 2024

Conversation

TApplencourt
Copy link
Collaborator

@TApplencourt TApplencourt commented Aug 28, 2024

Not really sure what was the bug, but the new version seem to work and the code is clearer.

Fix @colleeneb bug with the OpenCL Timeline

@TApplencourt TApplencourt requested review from Kerilk and bd4 August 28, 2024 20:18
@TApplencourt
Copy link
Collaborator Author

TApplencourt commented Aug 28, 2024

The CI is just due one more freasking time to the MPI. I have no clue, those bug have been fixed already 10 time...

On rank didn't exist the local barrier.

EDIT: Oh it's the sync_daemon_fs ... nice. This one is know to be racy if the apps doesn't call mpi_init / any kind of global barrier.

@TApplencourt TApplencourt changed the title fix start [draft] fix start Aug 29, 2024
@TApplencourt TApplencourt changed the title [draft] fix start Fix OpenCL Start Aug 29, 2024
@TApplencourt
Copy link
Collaborator Author

Rerun, the CI, is passing now. So please review.

@Kerilk Kerilk merged commit e1d1692 into master Aug 29, 2024
16 checks passed
@Kerilk Kerilk deleted the fix_ocl branch August 29, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants