Fabric mem rebased #292
Closed
Fabric mem rebased #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use dependency from Efficios deliverable. --------- Co-authored-by: Thomas Applencourt <[email protected]>
Enable usage of session rotation for lossless online trace consumption. --------- Co-authored-by: Thomas Applencourt <[email protected]>
* Make only local master do energy profiling. * Use ZES to query devices in order to get around affinity masks. * Use ZES for drivers as well. * set ZES * Update ze/tracer_ze_helpers.include.c Co-authored-by: Brice Videau <[email protected]> * Update ze/tracer_ze_helpers.include.c Co-authored-by: Brice Videau <[email protected]> * Update xprof/xprof.rb.in --------- Co-authored-by: Brice Videau <[email protected]> Co-authored-by: Thomas Applencourt <[email protected]>
Sampling Rewrite
|
You need to remove the 3 first commit from the PR (ecd8b20 and so). |
This reverts commit b919440.
|
|
TApplencourt
reviewed
Oct 1, 2024
| @@ -838,6 +835,17 @@ static void intializeFrequency() { | |||
| _sampling_freqDomainCounts[driverIdx][deviceIdx] = 0; | |||
| free(_sampling_hFrequencies[driverIdx][deviceIdx]); | |||
| } | |||
| for (uint32_t domainIdx = 0; domainIdx < _sampling_freqDomainCounts[driverIdx][deviceIdx]; domainIdx++) { | |||
| zes_freq_properties_t freqProps ={0}; | |||
There was a problem hiding this comment.
You can run clang format. to fix missing space
TApplencourt
reviewed
Oct 1, 2024
| for (uint32_t driverIdx = 0; driverIdx < _sampling_driverCount; driverIdx++) { | ||
| _sampling_freqDomainCounts[driverIdx] = (uint32_t*) calloc(_sampling_deviceCount[driverIdx], sizeof(uint32_t)); | ||
| _sampling_hFrequencies[driverIdx] = (zes_freq_handle_t**) calloc(_sampling_deviceCount[driverIdx], sizeof(zes_freq_handle_t*)); | ||
| for (uint32_t deviceIdx = 0; deviceIdx < _sampling_deviceCount[driverIdx]; deviceIdx++) { | ||
| // Get frequency domains for each device | ||
| _sampling_freqDomainCounts[driverIdx][deviceIdx] = 0; |
There was a problem hiding this comment.
Not required as it have be calloc so should already be 0 initialized
TApplencourt
reviewed
Oct 1, 2024
| res = ZES_DEVICE_ENUM_FABRIC_PORTS_PTR(_sampling_hDevices[driverIdx][deviceIdx], &_sampling_fabricPortCount[driverIdx][deviceIdx], NULL); | ||
| if (res != ZE_RESULT_SUCCESS) { | ||
| _ZE_ERROR_MSG("1st ZES_DEVICE_ENUM_FABRIC_PORTS_PTR", res); | ||
| _sampling_fabricPortCount[driverIdx][deviceIdx] = 0; |
There was a problem hiding this comment.
same already calloc (and 941 also)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.