Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby version Check #298

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Add Ruby version Check #298

merged 2 commits into from
Oct 11, 2024

Conversation

TApplencourt
Copy link
Collaborator

@TApplencourt TApplencourt commented Oct 11, 2024

  • 2.7.2 have be verified on Aurora (we should add test of ruby version on the CI -- either here or on the spack one)
  • Removing Endless rand to avoid a syntax error when try to run iprof with ruby 2.5 (default on aurora -- reported by @sbekele81 )
    (0..).each do |i|
        ^
/home/sbekele/fabric_stat/bin/iprof:234: syntax error, unexpected keyword_end, expecting ')'
  end
  ^~~

xprof/xprof.rb.in Outdated Show resolved Hide resolved
Kerilk
Kerilk previously approved these changes Oct 11, 2024
Co-authored-by: Brice Videau <[email protected]>
@Kerilk Kerilk merged commit 1655fd4 into master Oct 11, 2024
16 checks passed
@TApplencourt TApplencourt deleted the ruby_version branch October 11, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants